-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make systemtags public visible #48206
Open
skjnldsv
wants to merge
1
commit into
master
Choose a base branch
from
feat/systemtags-public
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
susnux,
artonge,
a team,
ArtificialOwl and
sorbaugh
and removed request for
a team
September 19, 2024 12:50
susnux
reviewed
Sep 19, 2024
skjnldsv
commented
Sep 19, 2024
skjnldsv
force-pushed
the
feat/systemtags-public
branch
from
September 19, 2024 13:05
7244306
to
e3a0f90
Compare
skjnldsv
requested review from
susnux,
nickvergessen,
icewind1991 and
come-nc
September 19, 2024 13:06
come-nc
requested changes
Sep 19, 2024
skjnldsv
force-pushed
the
feat/systemtags-public
branch
3 times, most recently
from
September 19, 2024 14:04
ba84f93
to
33403e1
Compare
come-nc
approved these changes
Sep 19, 2024
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
feat/systemtags-public
branch
from
September 19, 2024 17:52
663268a
to
9d535f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #40364
Of course if the tag is made invisible in the settings, it will also apply.
I'm also thinking if it would make sense to NOT show restricted tags on public