fix: add user settings #2795
Open
fix: add user settings #2795
+544
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oment) Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
The backend sends the items to the frontend in packets of 40 sorted by item id. In the unread, all articles or folder view this leads to the fact that new items that have been loaded can also be sorted above the items already displayed. Signed-off-by: Wolfgang <[email protected]>
…sabled Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
SMillerDev
reviewed
Oct 7, 2024
Comment on lines
+103
to
+117
| $usersettings = [ | ||
| 'compact', | ||
| 'compactExpand', | ||
| 'preventReadOnScroll', | ||
| 'oldestFirst', | ||
| 'showAll' | ||
| ]; | ||
| foreach ($usersettings as $setting) { | ||
| $this->initialState->provideInitialState($setting, $this->settings->getUserValue( | ||
| $this->getUserId(), | ||
| $this->appName, | ||
| $setting, | ||
| '0') | ||
| ); | ||
| } |
There was a problem hiding this comment.
Do you have some link to documentation for this? Based on the function naming this seems like something that should happen once and not for every API call.
There was a problem hiding this comment.
https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/js.html#loading-initial-state
Unfortunately it is nowhere explained where to put the php part, but looking at other apps like notes, deck. The all have it in the TemplateResponse of the PageController.
Co-authored-by: Sean Molenaar <[email protected]> Signed-off-by: Wolfgang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Things that are still missing here:
Checklist