Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct classes for settings and setting hints #2789

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

wofferl
Copy link
Contributor

@wofferl wofferl commented Sep 30, 2024

Summary

This fixes the TypeError when changing admin settings.

TypeError: this.$refs.field is undefined
    mounted index.mjs:35
    VueJS 9
    js</<.on["update:checked"]< AdminSettings.vue:1

Checklist

@Grotax
Copy link
Member

Grotax commented Oct 3, 2024

Hey thanks for this!

If you can, next time you make commits set the -s option so git commit -s -m ... ..... Or if you use some tool they will probably have some option to say commit with SignOff.

See here https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

@Grotax Grotax merged commit 56bb602 into nextcloud:master Oct 3, 2024
14 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants