Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local feedserver to test the logo/favicon logic #2631

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Use local feedserver to test the logo/favicon logic #2631

merged 1 commit into from
Mar 31, 2024

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Mar 31, 2024

  • Resolves: The issue that Nextcloud and heise change the path to the icon/logo every few months. Also no longer connecting to the internet should speed up the test a bit.

Summary

Use local feedserver in tests to check the feed logo-favicon logic. I used our app logo for this.

Checklist

@Grotax Grotax added API Impact API/Backend code Skip-Changelog No changelog update is required, minor change labels Mar 31, 2024
@Grotax Grotax requested a review from SMillerDev March 31, 2024 12:55
@Grotax Grotax merged commit f5dc9a6 into master Mar 31, 2024
22 of 23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/favicon branch March 31, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
API Impact API/Backend code Skip-Changelog No changelog update is required, minor change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Grotax @SMillerDev