Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7.4 new min. version is php 8.0 #2237

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented May 18, 2023

  • Resolves: #

Summary

Drop support for PHP 7.4 new min. version is php 8.0

Checklist

@Grotax Grotax mentioned this pull request May 18, 2023
@devlinjunker
Copy link
Contributor

What is this waiting on? Should we do it as same time as the Vue rewrite?

@Grotax
Copy link
Member Author

Grotax commented Aug 8, 2023

It was waiting for the last release and then for me to have time.
But I actually want to continue this now.

@Grotax Grotax marked this pull request as ready for review August 8, 2023 07:58
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -91.63% ⚠️

Comparison is base (fca05d5) 91.62% compared to head (447e087) 0.00%.
Report is 456 commits behind head on master.

❗ Current head 447e087 differs from pull request most recent head dafdf99. Consider uploading reports for the commit dafdf99 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2237       +/-   ##
============================================
- Coverage     91.62%       0   -91.63%     
============================================
  Files            65       0       -65     
  Lines          2724       0     -2724     
============================================
- Hits           2496       0     -2496     
+ Misses          228       0      -228     

see 64 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grotax Grotax merged commit de0db5d into master Aug 8, 2023
30 of 34 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove/PHP7.4 branch August 8, 2023 08:10
Grotax added a commit that referenced this pull request Aug 9, 2023
Changed
- Drop support for PHP 7.4 new min. version is php 8.0 (#2237)
- Upgrade feed-io to v5.1.3 (#2238)

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Aug 9, 2023
Grotax added a commit that referenced this pull request Aug 9, 2023
Changed
- Drop support for PHP 7.4 new min. version is php 8.0 (#2237)
- Upgrade feed-io to v5.1.3 (#2238)

Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax added a commit that referenced this pull request Aug 16, 2023
Changed
- Drop support for PHP 7.4 new min. version is php 8.0 (#2237)
- Upgrade feed-io to v5.1.3 (#2238)

Fixed
- Some feeds missing items (#2236)

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Aug 16, 2023
Grotax added a commit that referenced this pull request Aug 16, 2023
Changed
- Drop support for PHP 7.4 new min. version is php 8.0 (#2237)
- Upgrade feed-io to v5.1.3 (#2238)

Fixed
- Some feeds missing items (#2236)

Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants