fix: run phpcdf on tests

nextcloud · Sep 21, 2024 · a91be27 · a91be27
1 parent 9ecdcbb
commit a91be27
Show file tree

Hide file tree

Showing 32 changed files with 62 additions and 82 deletions.
diff --git a/tests/Unit/Controller/ExportControllerTest.php b/tests/Unit/Controller/ExportControllerTest.php
@@ -167,5 +167,4 @@ public function testGetAllArticles()
             $return->render()
         );
     }
-
 }
diff --git a/tests/Unit/Controller/FeedApiControllerTest.php b/tests/Unit/Controller/FeedApiControllerTest.php
@@ -286,7 +286,7 @@ public function testRead()
     {
         $this->feedService->expects($this->once())
             ->method('read')
-            ->with($this->userID,3,30);
+            ->with($this->userID, 3, 30);
 
         $this->class->read(3, 30);
     }
@@ -413,5 +413,4 @@ public function testUpdateError()
 
         $this->class->update($userId, $feedId);
     }
-
 }
diff --git a/tests/Unit/Controller/FeedControllerTest.php b/tests/Unit/Controller/FeedControllerTest.php
@@ -427,7 +427,8 @@ public function testCreateReturnsErrorForInvalidCreate()
 
         $this->assertEquals($msg, $params['message']);
         $this->assertEquals(
-            $response->getStatus(), Http::STATUS_UNPROCESSABLE_ENTITY
+            $response->getStatus(),
+            Http::STATUS_UNPROCESSABLE_ENTITY
         );
     }
 
@@ -782,6 +783,4 @@ public function testPatchDoesNotExistOnUpdate()
         $this->assertEquals('test', $params['message']);
         $this->assertEquals($response->getStatus(), Http::STATUS_NOT_FOUND);
     }
-
-
 }
diff --git a/tests/Unit/Controller/FolderApiControllerTest.php b/tests/Unit/Controller/FolderApiControllerTest.php
@@ -31,7 +31,6 @@
 
 use PHPUnit\Framework\TestCase;
 
-
 class FolderApiControllerTest extends TestCase
 {
 
@@ -89,7 +88,8 @@ public function testIndex()
         $this->assertEquals(
             [
             'folders' => [$folders[0]->toAPI()]
-            ], $response
+            ],
+            $response
         );
     }
 
@@ -113,7 +113,8 @@ public function testCreate()
         $this->assertEquals(
             [
             'folders' => [$folder->toAPI()]
-            ], $response
+            ],
+            $response
         );
     }
 
@@ -153,7 +154,8 @@ public function testCreateInvalidFolderName()
         $data = $response->getData();
         $this->assertEquals($msg, $data['message']);
         $this->assertEquals(
-            Http::STATUS_UNPROCESSABLE_ENTITY, $response->getStatus()
+            Http::STATUS_UNPROCESSABLE_ENTITY,
+            $response->getStatus()
         );
     }
 
@@ -260,7 +262,8 @@ public function testUpdateInvalidFolderName()
         $data = $response->getData();
         $this->assertEquals($this->msg, $data['message']);
         $this->assertEquals(
-            Http::STATUS_UNPROCESSABLE_ENTITY, $response->getStatus()
+            Http::STATUS_UNPROCESSABLE_ENTITY,
+            $response->getStatus()
         );
     }
 
@@ -278,15 +281,11 @@ public function testUpdateRoot()
     {
         $response = $this->class->update(null, '');
         $this->assertSame(400, $response->getStatus());
-
     }
 
     public function testDeleteRoot()
     {
         $response = $this->class->delete(null);
         $this->assertSame(400, $response->getStatus());
-
     }
-
-
 }
diff --git a/tests/Unit/Controller/FolderControllerTest.php b/tests/Unit/Controller/FolderControllerTest.php
@@ -306,5 +306,4 @@ public function testRestoreConflict()
         $this->assertEquals(Http::STATUS_CONFLICT, $response->getStatus());
         $this->assertEquals($this->msg, $params['message']);
     }
-
-}
+}
diff --git a/tests/Unit/Controller/ItemApiControllerTest.php b/tests/Unit/Controller/ItemApiControllerTest.php
@@ -27,7 +27,6 @@
 
 use PHPUnit\Framework\TestCase;
 
-
 class ItemApiControllerTest extends TestCase
 {
     /**

diff --git a/tests/Unit/Controller/ItemControllerTest.php b/tests/Unit/Controller/ItemControllerTest.php
@@ -30,7 +30,6 @@
 use OCP\IUserSession;
 use PHPUnit\Framework\TestCase;
 
-
 class ItemControllerTest extends TestCase
 {
 
@@ -624,6 +623,4 @@ public function testGetNewItemsNoNewestItemsId()
         $response = $this->controller->newItems(ListType::FEED, 2, 3);
         $this->assertEquals([], $response);
     }
-
-
 }
diff --git a/tests/Unit/Controller/JSONHttpErrorTest.php b/tests/Unit/Controller/JSONHttpErrorTest.php
@@ -29,12 +29,10 @@ public function testError()
         $this->assertEquals(['message' => 'hi'], $result->getData());
         $this->assertEquals(3, $result->getStatus());
     }
-
-
 }
 
 
 class DummyTraitingClass
 {
     use JSONHttpErrorTrait;
-}
+}
diff --git a/tests/Unit/Controller/PageControllerTest.php b/tests/Unit/Controller/PageControllerTest.php
@@ -275,7 +275,6 @@ public function testExplore()
         $out = $this->controller->explore('en');
 
         $this->assertEquals($in, $out);
-
     }
 
     public function testExploreError()
@@ -295,7 +294,5 @@ public function testExploreError()
         $out = $this->controller->explore('nl');
 
         $this->assertEquals(404, $out->getStatus());
-
     }
-
 }
diff --git a/tests/Unit/Controller/UtilityApiControllerTest.php b/tests/Unit/Controller/UtilityApiControllerTest.php
@@ -145,6 +145,4 @@ public function testStatus()
 
         $this->assertEquals($in, $result);
     }
-
-
 }
diff --git a/tests/Unit/Db/FeedMapperTest.php b/tests/Unit/Db/FeedMapperTest.php
@@ -49,7 +49,6 @@ protected function setUp(): void
         $feed2->resetUpdatedFields();
 
         $this->feeds = [$feed1, $feed2];
-
     }
 
     /**

diff --git a/tests/Unit/Db/FeedTest.php b/tests/Unit/Db/FeedTest.php
@@ -63,7 +63,8 @@ public function testToAPI()
                 'updateErrorCount' => 2,
                 'lastUpdateError' => 'hi',
                 'items' => [],
-            ], $feed->toAPI()
+            ],
+            $feed->toAPI()
         );
     }
 
@@ -121,7 +122,8 @@ public function testSerialize()
             'lastUpdateError' => 'hi',
             'basicAuthUser' => 'user',
             'basicAuthPassword' => 'password'
-            ], $feed->jsonSerialize()
+            ],
+            $feed->jsonSerialize()
         );
     }
 
@@ -200,6 +202,4 @@ public function testSetPinned()
         $feed->setPinned(true);
         $this->assertEquals(true, $feed->getPinned());
     }
-
-
 }
diff --git a/tests/Unit/Db/FolderTest.php b/tests/Unit/Db/FolderTest.php
@@ -33,7 +33,8 @@ public function testToAPI()
                 'name' => 'name',
                 'opened' => false,
                 'feeds' => [],
-            ], $folder->toAPI()
+            ],
+            $folder->toAPI()
         );
     }
 
@@ -75,7 +76,8 @@ public function testSerialize()
             'userId' => 'abc',
             'opened' => true,
             'deletedAt' => 9,
-            ], $folder->jsonSerialize()
+            ],
+            $folder->jsonSerialize()
         );
     }
     public function testSetDeletedAt()

diff --git a/tests/Unit/Db/ItemMapperAfterTest.php b/tests/Unit/Db/ItemMapperAfterTest.php
@@ -585,5 +585,4 @@ public function testFindAllAfterInvalid()
         $result = $this->class->findAllAfter('jack', 232, 1610903351);
         $this->assertEquals([Item::fromRow(['id' => 4])], $result);
     }
-
 }
diff --git a/tests/Unit/Db/ItemMapperPaginatedTest.php b/tests/Unit/Db/ItemMapperPaginatedTest.php
@@ -1276,5 +1276,4 @@ public function testFindAllFolderSearchId()
         $result = $this->class->findAllFolder('jack', 2, 10, 10, false, false, ['key', 'word']);
         $this->assertEquals([Item::fromRow(['id' => 4])], $result);
     }
-
 }
diff --git a/tests/Unit/Db/ItemMapperTest.php b/tests/Unit/Db/ItemMapperTest.php
@@ -1113,5 +1113,4 @@ public function testDeleteOverThresholdSuccessUnreadSkipsIfUnderThreshold()
         $res = $this->class->deleteOverThreshold(3, false);
         $this->assertSame(10, $res);
     }
-
 }
diff --git a/tests/Unit/Db/ItemTest.php b/tests/Unit/Db/ItemTest.php
@@ -228,7 +228,8 @@ public function testJSONSerialize()
             'categories' => ['food'],
             'sharedBy' => 'jack',
             'sharedByDisplayName' => 'Jack'
-            ], $item->jsonSerialize()
+            ],
+            $item->jsonSerialize()
         );
     }
 
@@ -274,7 +275,8 @@ public function testToExport()
             'starred' => true,
             'feedLink' => 'http://test',
             'rtl' => true
-            ], $item->toExport($feeds)
+            ],
+            $item->toExport($feeds)
         );
     }
 

diff --git a/tests/Unit/Db/NewsMapperTest.php b/tests/Unit/Db/NewsMapperTest.php
@@ -25,7 +25,8 @@
  *
  * @package OCA\News\Tests\Unit\Db
  */
-abstract class TmpNewsMapper extends NewsMapperV2 {
+abstract class TmpNewsMapper extends NewsMapperV2
+{
     const TABLE_NAME = 'NAME';
 }
 
@@ -272,4 +273,4 @@ public function testPurgeBoth()
 
         $result = $this->class->purgeDeleted('jack', 1);
     }
-}
+}
diff --git a/tests/Unit/Fetcher/FeedIoClientTest.php b/tests/Unit/Fetcher/FeedIoClientTest.php
@@ -3,7 +3,6 @@
 
 namespace OCA\News\Tests\Unit\Fetcher;
 
-
 use DateTime;
 use FeedIo\Adapter\Guzzle\Response;
 use FeedIo\Adapter\NotFoundException;
@@ -89,4 +88,4 @@ public function testGetResponseThrows(): void
 
         $this->class->getResponse('url', new DateTime('@0'));
     }
-}
+}
diff --git a/tests/Unit/Fetcher/FetcherTest.php b/tests/Unit/Fetcher/FetcherTest.php
@@ -24,7 +24,6 @@
 
 namespace OCA\News\Tests\Unit\Fetcher;
 
-
 use OCA\News\Fetcher\Fetcher;
 use OCA\News\Fetcher\IFeedFetcher;
 use PHPUnit\Framework\TestCase;
@@ -142,6 +141,4 @@ public function testMultipleFetchersOnlyOneShouldHandle()
 
         $this->assertEquals($return, $result);
     }
-
-
 }
diff --git a/tests/Unit/Search/ItemSearchProviderTest.php b/tests/Unit/Search/ItemSearchProviderTest.php
@@ -116,7 +116,8 @@ public function testSearch()
                                 10,
                                 0,
                                 false,
-                                ['some text'])
+                                ['some text']
+                            )
                             ->willReturn($items);