Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mozilla Firefox user agent to import script #2515

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented Sep 20, 2024

Topic and Scope

This should help to make the import more stable.

Concerns/issues

We need to check if this solution helps and keep the sent FF version somewhat up to date.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus christianlupus marked this pull request as ready for review September 20, 2024 15:33
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

Copy link

Test Results

   12 files    584 suites   1m 37s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
2 300 runs  2 299 ✅ 1 💤 0 ❌

Results for commit ad9ae3d.

@christianlupus christianlupus merged commit 60b0710 into master Sep 20, 2024
34 checks passed
@christianlupus christianlupus deleted the fix/use-firefox-headers-for-import branch September 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants