close #109 | fix HTML validation errors in index.html #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #115. |
lucagrementieri
approved these changes
Mar 1, 2019
| @@ -25,10 +25,6 @@ | |||
| <meta name="twitter:description" content="Rapido: semantic HTML elements for your writings."> | |||
| <!-- <meta name="twitter:image" content="https://nextbitlabs.github.io/Rapido/images/intro.png"> --> | |||
|
|
|||
| <meta itemprop="name" content="Rapido"> | |||
| <meta itemprop="description" content="Rapido: semantic HTML elements for your writings."> | |||
There was a problem hiding this comment.
Why do you have to remove this meta tags?
Isn't there any option to include valid custom meta tag?
There was a problem hiding this comment.
Good question! The HTML validator emits an error on those lines: Validation error: “The itemprop attribute was specified, but the element is not a property of any item. Actually, itemprop attributes refer to itemscope and itemtype attributes, which are not present.
Therefore there is the option to include valid tags, but adding microdata is the scope of issue #84, so I prefer to address this problem in that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used https://validator.w3.org/nu/?doc=https%3A%2F%2Fnextbitlabs.github.io%2FRapido%2F as HTML validator.