OpenSearch instrumentation #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
commented
Aug 7, 2024
kaylareopelle
commented
Aug 7, 2024
Postpone the addition of OpenSearch to the CI until a later date. The tests pass locally with a separate docker container using instructions documented in docker-compose. Skip the suite on the CI.
kaylareopelle
changed the title
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
previously approved these changes
Aug 9, 2024
kaylareopelle
commented
Aug 12, 2024
fallwith
reviewed
Aug 12, 2024
lib/new_relic/agent/instrumentation/opensearch/instrumentation.rb
Outdated
Show resolved
Hide resolved
lib/tasks/instrumentation_generator/templates/dependency_detection.tt
Outdated
Show resolved
Hide resolved
…elic-ruby-agent into opensearch-instrumentation
SimpleCov Report
|
Use NewRelic::EMPTY_HASH for the params default Make _opts default nil
fallwith
approved these changes
Aug 12, 2024
hannahramadan
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSearch Instrumentation
Follows the patterns established in the Elasticsearch instrumentation
Todo:
Resolves #2228