Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sunset Tessen #15866

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Sunset Tessen #15866

merged 7 commits into from
Jan 30, 2024

Conversation

tabathadelane
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Hi @tabathadelane 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added the eng issues related to site functionality that requires engineering label Jan 18, 2024
@gatsby-cloud Gatsby Cloud
Copy link

gatsby-cloud bot commented Jan 18, 2024 •
edited
Loading

✅ docs-website-develop deploy preview ready

@clarkmcadoo clarkmcadoo marked this pull request as ready for review January 25, 2024 23:00
@clarkmcadoo clarkmcadoo requested a review from a team as a code owner January 25, 2024 23:00
@clarkmcadoo clarkmcadoo requested review from sunnyzanchi and clarkmcadoo and removed request for a team January 25, 2024 23:00
clarkmcadoo
clarkmcadoo reviewed Jan 25, 2024
View reviewed changes
gatsby/on-route-update.js Outdated
location.hash &&
location.pathname !== prevLocation?.pathname
) {
window.Tessen.track({
window.newrelic.track({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be Segment or Browser Agent? If its browser agent, it could either import the addPageAction function or use the global but with .addPageAction vs .track

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won't be using segment in these sites outside of setting the config options. It should be browser agent

Copy link
Contributor

@clarkmcadoo clarkmcadoo Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use the browser agent method setCustomAttribute()!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been added and we can see hashRequest values in browser events now.

@tabathadelane tabathadelane merged commit ad59107 into develop Jan 30, 2024
14 checks passed
@tabathadelane tabathadelane deleted the tabatha/sunset-tessen branch January 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizBaker LizBaker LizBaker left review comments

@clarkmcadoo clarkmcadoo clarkmcadoo approved these changes

@sunnyzanchi sunnyzanchi Awaiting requested review from sunnyzanchi sunnyzanchi is a code owner automatically assigned from newrelic/docs-engineering

Assignees
No one assigned
Labels
eng issues related to site functionality that requires engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabathadelane @clarkmcadoo @LizBaker