Update opentelemetry docs to prefer OTLP http/protobuf over grpc #15846
Conversation
|
Hi @jack-berg 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
There was a problem hiding this comment.
This file was odd. It doesn't appear in the navigation, but is linked to by the metrics best practices page.
The problem is that the page is wrong. It seems to be a copy / paste of the python getting started guide, but was never updated to actually be a go getting started guide like the title states.
Better to delete the document for now and re-add it when someone wants to properly add a go getting started page.
cc @reese-lee who committed the page
✅ docs-website-develop deploy preview ready
|
…to opentelemetry-http-protobuf
...open-source-telemetry-integrations/opentelemetry/get-started/opentelemetry-tutorial-java.mdx
Outdated
Show resolved
Hide resolved
...open-source-telemetry-integrations/opentelemetry/get-started/opentelemetry-tutorial-java.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
There was a problem hiding this comment.
@jack-berg thanks for tackling this sweeping update! This looks good!
jeff-colucci
added
content
|
@jeff-colucci is there automated tooling for resolving the merge conflicts or should I take care of that? |
|
@jack-berg Unfortunately, there is no automated tool that I'm aware of for branch conflicts, so they have to be resolved manually. I'm not sure where these branch conflicts came from since they weren't there when I approved the request I don't think. |
…to opentelemetry-http-protobuf
There was a problem hiding this comment.
@jack-berg Are these android gradle/studio files related to OpenTelemetry? Why are they being deleted?
There was a problem hiding this comment.
I don't know. I didn't commit those changes [see commit here]. I assumed it was some sort of unrelated automated cleanup required to get the develop branch back healthy which was just being bundled with this PR by coincidence, but @rhetoric101 and @jeff-colucci may know more.
There was a problem hiding this comment.
The file I commented on went away, but there are still a few others.
There was a problem hiding this comment.
Hi guys! Thanks for fixing this. I was able to track down that there was a script that was run that deleted some orphaned translated files, and that seems to be where the discrepancy came from. I'm going to re-check the files now to make sure there are no more issues. We have an auto-translator that does our translation work for us, so if a translated doc that doesn't cause branch commits gets deleted, that translator will re-translate the files so we won't actually lose anything.
Apologies for the confusion and thanks for patiently sticking with us while we get this ticket worked on. Assuming there are no more branch conflicts I will go ahead and get this merged and we can mark it as done!
The grpc version of OTLP causes problems compared to http/protobuf. This PR updates all the OpenTelemetry docs to prefer http/protobuf.
The OpenTelemetry docs reference examples in newrelic/newrelic-opentelemetry-examples. The following PRs update all the examples in that repo to prefer http/protobuf over grpc as well: