Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs-agent-configuration.mdx #13952

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

tytyhibye
Copy link
Contributor

per the Node Agent repo, browser monitoring is set to false by default.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

per the Node Agent repo, browser monitoring is set to false by default.
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

Hi @tytyhibye 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@akristen akristen self-assigned this Jul 21, 2023
@akristen akristen added from_internal Identifies issues/PRs from Relics (except writers) content requests related to docs site content labels Jul 21, 2023
@akristen
Copy link
Contributor

Hi @tytyhibye! Can you sign the CLA so we can get this merged? Thanks!

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 21, 2023

✅ docs-website-develop deploy preview ready

Copy link
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akristen akristen merged commit b87ec9f into newrelic:develop Jul 21, 2023
14 checks passed
@brnhensley
Copy link
Contributor

Hye @tytyhibye would you also update the despription text:

Generate JavaScript headers for browser instrumentation. Although this defaults to true, the agent doesn't inject the browser JS code unless you have enabled browser monitoring. Even if you have enabled it and added the browser timing header, you can disable browser monitoring for your app by setting this to false.

Feel free to use this, I was going to add it to your PR, but I'm not savvy enough to push to this PR:

Generate JavaScript headers for browser instrumentation. Even when set to true, the agent doesn't inject the browser JS code unless you have enabled browser monitoring. Even if you have enabled it and added the browser timing header, you can disable browser monitoring for your app by setting this to false.

cut/paste md version

Generate JavaScript headers for browser instrumentation. Even when set to `true`, the agent doesn't inject the browser JS code unless you have [enabled browser monitoring](https://docs.newrelic.com/docs/browser/new-relic-browser/installation-configuration/adding-apps-new-relic-browser/). Even if you have enabled it and [added the browser timing header](https://docs.newrelic.com/docs/agents/nodejs-agent/supported-features/page-load-timing-nodejs/#procedures), you can [disable browser monitoring for your app](https://docs.newrelic.com/docs/agents/nodejs-agent/supported-features/page-load-timing-nodejs/#disabling) by setting this to `false`.

@brnhensley
Copy link
Contributor

ha, I was seconds too late I'll make a new PR

@brnhensley
Copy link
Contributor

#13955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants