Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump deps #ntrn-66 #103

Merged
merged 7 commits into from
Aug 1, 2023
Merged

chore: bump deps #ntrn-66 #103

merged 7 commits into from
Aug 1, 2023

Conversation

NeverHappened
Copy link
Contributor

@NeverHappened NeverHappened commented Jul 24, 2023 •
edited
Loading

@NeverHappened NeverHappened self-assigned this Jul 24, 2023
@NeverHappened NeverHappened mentioned this pull request Jul 24, 2023
Merged
foxpy
foxpy requested changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import all definitions from base64::prelude module, this is the idiomatic way to use all ::prelude packages in Rust.

contracts/neutron_interchain_queries/src/testing/tests.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_queries/src/testing/tests.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_queries/src/testing/tests.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_queries/src/testing/tests.rs Outdated Show resolved Hide resolved
contracts/neutron_interchain_queries/src/testing/tests.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/interchain_queries/v045/testing.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/interchain_queries/v045/testing.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/interchain_queries/v045/testing.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/interchain_queries/v045/testing.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/interchain_queries/v045/testing.rs Outdated Show resolved Hide resolved
@NeverHappened NeverHappened requested a review from foxpy July 31, 2023 14:22
pr0n00gler
pr0n00gler previously approved these changes Jul 31, 2023
View reviewed changes
@pr0n00gler pr0n00gler merged commit 4528662 into main Aug 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@foxpy foxpy foxpy approved these changes

Assignees

@NeverHappened NeverHappened

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeverHappened @pr0n00gler @foxpy