feat: flashloans #304
Open
feat: flashloans #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2024 10:58
# Conflicts: # package.json
# Conflicts: # package.json
sdk 50 NTRN-230
…tf-v4 chore: bump neutronjsplus to comply with tf v4
NeverHappened
requested changes
Jun 21, 2024
sotnikov-s
requested changes
Jun 27, 2024
Comment on lines
+111
to
+112
| const expiration = new Date(); | ||
| expiration.setDate(expiration.getDate() + 1); |
There was a problem hiding this comment.
is this safe? what would happen if we run integration tests in the last day of a month? will e.g. 31+1 work correct and set the expiration date to the next month's first date?
besides, why even use any expiration in MsgGrant? wouldn't null be the best option?
| JSON.stringify({ | ||
| request_loan: { | ||
| flashloans_contract: neutronFlashloansAddress, | ||
| execution_mode: 1, // MODE_WITHHOLD_LOAN |
There was a problem hiding this comment.
Suggested change
| execution_mode: 1, // MODE_WITHHOLD_LOAN | |
| execution_mode: 2, // MODE_RETURN_LOAN_MORE_THAN_NECESSARY |
| JSON.stringify({ | ||
| request_loan: { | ||
| flashloans_contract: neutronFlashloansAddress, | ||
| execution_mode: 3, // MODE_WITHHOLD_LOAN |
There was a problem hiding this comment.
Suggested change
| execution_mode: 3, // MODE_WITHHOLD_LOAN | |
| execution_mode: 3, // MODE_REQUEST_ANOTHER_LOAN_RECURSIVELY |
feat: whitelist tf hooks
# Conflicts: # package.json
fix: add test that empty metadata_JSON does not break deserialization #ntrn-346
Feat: icqr dynamic fees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the
neutron-flashloanscontract (neutron-org/neutron-dao#105).The following test cases were implemented:
Feel free to suggest more test cases.