goflow2: use slog instead of logrus #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Base one is less fancy without colors. Native JSON rendering is useful. {"time":"2023-08-09T21:43:07.940616-07:00","level":"INFO","msg":"starting GoFlow2"}
{"time":"2023-08-09T21:43:07.941039-07:00","level":"INFO","msg":"starting collection","scheme":"sflow","hostname":"","port":6343,"count":1}
{"time":"2023-08-09T21:43:07.941242-07:00","level":"INFO","msg":"starting collection","scheme":"netflow","hostname":"","port":2055,"count":1}
{"time":"2023-08-09T21:43:09.525804-07:00","level":"INFO","msg":"receiver closed","scheme":"sflow","hostname":"","port":6343,"count":1}
{"time":"2023-08-09T21:43:09.525828-07:00","level":"INFO","msg":"transporter closed"}
{"time":"2023-08-09T21:43:09.525854-07:00","level":"INFO","msg":"receiver closed","scheme":"netflow","hostname":"","port":2055,"count":1}
{"time":"2023-08-09T21:43:09.52589-07:00","level":"INFO","msg":"closed HTTP server","http":":8080"} |
lspgn
added
enhancement
lspgn
force-pushed
the
goflow2/use-slog
branch
2 times, most recently
from
cb08412
to
1dc6e85
Compare
This removes the `logrus` dependency as it's in maintenance-only mode.
lspgn
force-pushed
the
goflow2/use-slog
branch
from
1dc6e85
to
ae7338d
Compare
|
👍 for adding this, logrus is also super slow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
logrusdependency as it's in maintenance-only mode.Haven't used
slogbefore and it's pretty new. Looking for feedbacks.