Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Checks for NDFC Connectivity & Authorization #145

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

mtarking
Copy link
Collaborator

@mtarking mtarking commented Jul 1, 2024

This PR resolves #104
Add test checks for NDFC & Switch connectivity & authorization in the validate role after schema and rule tests.

Need to determine if we want a control knob to turn these connectivity and auth tests on & off.

@mtarking mtarking added the v2 label Jul 1, 2024
@mtarking mtarking self-assigned this Jul 1, 2024
@rrahimm
Copy link
Collaborator

rrahimm commented Jul 1, 2024

@mtarking

i believe we should have control knobs to turn these on/off.

There could be the scenario, where our solution will just be provided access to NDFC alone (as that is enough to run the solution). So, the tests towards Switches directly would fail.

So, we may have a default of Checking NDFC and not checking switches, and allow users to control with flags.

@juburnet juburnet marked this pull request as ready for review July 10, 2024 14:11
@juburnet
Copy link
Collaborator

@mtarking I reviewed this. Perhaps we should break this PR into 2 pieces.
It works well for the ndfc checks. It succeeds when all is good, and it fails for timeout and for authentication issues.

For the switch tests I'm unable to do a successful test because my laptop/Ansible doesn't have access to the switches directly. I agree with previous comments that the control knob is required for switches. For DTC we ideally want to test connectivity and credentials from the NDFC. Not sure if it's possible, or if we want to basically do a discovery and see what's manageable.

If we split this PR, we could go ahead and implement the NDFC checks. Otherwise, we need the controls for switches, with a default of false, before we implement.

@mtarking mtarking changed the title Add Test Checks for NDFC & Switch Connectivity & Authorization Add Test Checks for NDFC Connectivity & Authorization Jul 12, 2024
@mtarking
Copy link
Collaborator Author

@juburnet please review again as I checked a few things with the NDFC check. Thanks.

Copy link
Collaborator

@juburnet juburnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. Failures occur quickly for NDFC timeout or creds issues, and it works perfectly when connectivity to NDFC is good.
Thanks @mtarking

@juburnet juburnet merged commit 9fc259b into develop Jul 12, 2024
6 checks passed
@juburnet juburnet deleted the issue-104 branch July 12, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate role should validate the connectivity to the fabric in the beginning of the playbook validate role
3 participants