Refactor Example and ExampleGroup #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelsanzn
force-pushed
the
refactor-example-and-example-group
branch
from
55beb7d
to
79093ca
Compare
angelsanzn
force-pushed
the
refactor-example-and-example-group
branch
2 times, most recently
from
4306c77
to
82f4f29
Compare
added 8 commits
April 2, 2016 19:00
They are unnecessary and can be re-introduced witout breaking anything whenever they are needed.
…_failed` This helps make it more explicit that errors can only be set once, because the code checking for the condition is close to the code implementing the actions that must happen if the condition occurs.
angelsanzn
force-pushed
the
refactor-example-and-example-group
branch
from
a504544
to
34b228f
Compare
angelsanzn
force-pushed
the
refactor-example-and-example-group
branch
from
34b228f
to
15ff01e
Compare
added 3 commits
April 2, 2016 19:38
This documents why it is necessary to delete the property even when subject instantiation fails: parents of the example group may have already set a 'subject' property.
angelsanzn
force-pushed
the
refactor-example-and-example-group
branch
from
7df4e26
to
2f9fc16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes which I think improve those classes as well.