-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ExampleCollector #67
base: master
Are you sure you want to change the base?
Refactor ExampleCollector #67
Commits on Feb 4, 2016
-
ExampleCollector: renames to make expicit the nature of the paths inv…
…olved
Ángel Sanz committedFeb 4, 2016 Configuration menu - View commit details
-
Copy full SHA for 1f92987 - Browse repository at this point
Copy the full SHA 1f92987View commit details -
ExampleCollector: extract
_is_name_of_spec_file
methodÁngel Sanz committedFeb 4, 2016 Configuration menu - View commit details
-
Copy full SHA for f5299cd - Browse repository at this point
Copy the full SHA f5299cdView commit details
Commits on Feb 5, 2016
-
ExampleCollector: refactor
_collect_spec_files_in_directory
Rename some variables to make explicit that they are file names, not files, and paths, not directories. Extract a method for creating path to spec files. Ignore the second item in the tuples returned by os.walk. Adjust indendation
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for e3e38e7 - Browse repository at this point
Copy the full SHA e3e38e7View commit details -
ExampleCollector: extract
_dump_file_extension
methodÁngel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for dff7c98 - Browse repository at this point
Copy the full SHA dff7c98View commit details -
ExampleCollector: extract a constant
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 0532bf6 - Browse repository at this point
Copy the full SHA 0532bf6View commit details -
ExampleCollector: further qualify names of variables holding paths
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 3683344 - Browse repository at this point
Copy the full SHA 3683344View commit details -
ExampleCollector: extract module creation logic from _module_from_ast
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 40f8d3b - Browse repository at this point
Copy the full SHA 40f8d3bView commit details -
ExampleCollector: narrow the scope of a try-except clause
Only the call to __import__ can throw. So we can use a for-else to make explicit what should be done in case it doesn't throw.
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for dbd040f - Browse repository at this point
Copy the full SHA dbd040fView commit details -
ExampleCollector: use a context manager for allowing
the importing of local non-installed modules
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for a3542a2 - Browse repository at this point
Copy the full SHA a3542a2View commit details -
ExampleCollector: extract two methods providing higher-level descript…
…ions
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 79a0d7a - Browse repository at this point
Copy the full SHA 79a0d7aView commit details -
ExampleCollector: narrow the scope of a with statement
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for d55b140 - Browse repository at this point
Copy the full SHA d55b140View commit details -
ExampleCollector: inline a variable
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for d993032 - Browse repository at this point
Copy the full SHA d993032View commit details -
ExampleCollector: reorder method declarations to match reading order
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 8eda791 - Browse repository at this point
Copy the full SHA 8eda791View commit details -
ExampleCollector: extract logic for importing packages to its own method
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for eb469f1 - Browse repository at this point
Copy the full SHA eb469f1View commit details -
ExampleCollector: simplify
_load_module_from
- no need to use a con……text manager There is no real setup/teardown work needing to be done in that method, it just prepares the module name and delegates to another method. So using a context manager adds little benefit. This also simplifies the implementation of ExampleCollector#modules a bit more.
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 8ce6e66 - Browse repository at this point
Copy the full SHA 8ce6e66View commit details -
ExampleCollector: enhance names
- Give more information about the code object. - Decouple _create_module_object from its particular usage in the class.
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 64cebe1 - Browse repository at this point
Copy the full SHA 64cebe1View commit details -
ExampleCollector: _parse_and_transform_ast -> _transform_ast_of_sourc…
…e_code_at
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for c2fd033 - Browse repository at this point
Copy the full SHA c2fd033View commit details -
ExampleCollector: split _transform_ast_of_source_code_at in smaller m…
…ethods
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 0c1069e - Browse repository at this point
Copy the full SHA 0c1069eView commit details -
ExampleCollector: extract
_walk_directory_from_top_to_bottom
Ángel Sanz committedFeb 5, 2016 Configuration menu - View commit details
-
Copy full SHA for 01ac426 - Browse repository at this point
Copy the full SHA 01ac426View commit details
Commits on Apr 10, 2016
-
- Remove unnecessary conversion to list - Remove old unused variable binding in with statement
Ángel Sanz committedApr 10, 2016 Configuration menu - View commit details
-
Copy full SHA for 7226184 - Browse repository at this point
Copy the full SHA 7226184View commit details