Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ApplicationFactory #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor ApplicationFactory #64

wants to merge 3 commits into from

Commits on Dec 3, 2015

  1. ApplicationFactory: remove unused private _instances field 

    It isn't being used anywhere.
    Ángel Sanz committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    0f99c9c View commit details
    Browse the repository at this point in the history

  2. ApplicationFactory: remove trailing slash in local variable name `set… 

    …tings_`

This uses a namespaced import to avoid creating a local
variable 'settings' with the import statement, which was
the reason why a trailing slash was used to avoid shadowing
that variable.
    Ángel Sanz committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    558b6aa View commit details
    Browse the repository at this point in the history

  3. ApplicationFactory: mark arguments field as private

    Ángel Sanz committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    f16cc5e View commit details
    Browse the repository at this point in the history