Fix multiple hook execution #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nestorsalceda Just mentioning you to be safe... Sorry if you're busy I'm also thinking about implementing a JUnit formatter (for CircleCI integration) soon in addition to the two Pull Requests that are out right now |
|
Auch! I didn't see this before! Sorry man! Let me to check this and merge this weekend, but it looks good! |
|
#131 has a more comprehensive fix to this problem I think, so this one could be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in issue #105, before_all and after_all hooks were executed several times (but only if the nested context had a hook of the same kind).
This Pull Request should fix the issue.