Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete TODO tasks in the environment setup doc #166

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

kispaljr
Copy link
Contributor

The following TODO tasks explicitly mentioned in the text were completed, thus removed from the docs:

  • WSL2 with Docker Desktop setup was checked and working as expected
  • sed is no longer used as part of the mainstream dev process, and in the Google-specific parts, where it is still used, it doesn't require POSIX specific behavior

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 43a7be7
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66c720588be45f0008db0391
😎 Deploy Preview https://deploy-preview-166--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Aug 29, 2024
@nephio-prow nephio-prow bot merged commit e212688 into nephio-project:main Aug 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants