Update config-sync pkg to 1.18.3 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiacor
requested review from
radoslawc,
kispaljr,
tliron,
liamfallon,
vjayaramrh,
johnbelamaric and
henderiw
and removed request for
s3wong
arora-sagar
reviewed
Aug 24, 2024
vjayaramrh
reviewed
Aug 29, 2024
| @@ -1,6 +1,6 @@ | |||
| apiVersion: configmanagement.gke.io/v1 | |||
| kind: ConfigManagement | |||
| metadata: # kpt-merge: /config-management | |||
There was a problem hiding this comment.
what is the reason for removing the text after #?
There was a problem hiding this comment.
I'm pretty sure we don't need it.
https://kpt.dev/reference/cli/pkg/update/?id=resource-identity
I'm guessing the orig pkg was created using kpt but as it stands we don't need to customize the pkg further.
@johnbelamaric @henderiw could you confirm?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nephio-project/nephio#800
The addition of the git.period value in the RootSync resource was added to assess a better value for this.
https://cloud.google.com/kubernetes-engine/enterprise/config-sync/docs/reference/rootsync-reposync-fields#configuring-git-repo
The default value is unchanged at 15 sec.