-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new
] PART-1 NamedPipeService
#3452
base: master
Are you sure you want to change the base?
[new
] PART-1 NamedPipeService
#3452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this plugin only send the exceptions?
src/Plugins/NamedPipeService/Configuration/NamedPipeServerTransportOptions.cs
Show resolved
Hide resolved
|
||
namespace Neo.Plugins.Models.Payloads | ||
{ | ||
internal sealed class PipeNullPayload : IPipeMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need it? maybe ping, but null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you request a Block
for example. If may not be at the that height yet or doesn't exists (if you request something else). In this case we return null
. Could return exception too depending on what it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In short, just for empty protocol messages. Like command GetBlockHeight
Does both will send and log to |
…t88/neo into add/plugins/namedpipe
Description
What this service does, is allow communication with the node, when it is running as a
windows service
orsystemd service
. Communication between theneo-cli
and node, allowing a developer to receive all, if not more information from the node.Type of change
How Has This Been Tested?
Checklist: