Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Part-7 Classes into Different Library - Neo.Extensions #3446

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

cschuchardt88
Copy link
Member

Description

Reorganized and move classes from neo library to neo.extensions library.

Fixed problems and warnings that occurred. Along with naming violations.

Change Log

  • Moved methods from Neo.VM.Helper class
  • Added ScriptBuilderExtensions class
  • Added using statement
  • Fixed typo with StringExtensions class and filename
  • Fixed unit tests

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cschuchardt88 and others added 30 commits July 2, 2024 04:46
…`, `AssemblyExtensions`, `StringExtensdions`

Deleted `Helper.cs` file
@cschuchardt88 cschuchardt88 added the blocked This issue can't be worked at the moment label Aug 3, 2024
Comment on lines +18 to +28
public static void Remove<T>(this HashSet<T> set, ISet<T> other)
{
if (set.Count > other.Count)
{
set.ExceptWith(other);
}
else
{
set.RemoveWhere(u => other.Contains(u));
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( Does set.Remove(other) have any difference from set.ExceptWith(other), even when set.Count <= other.Count? )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue. I'm just moving the method to appropriate namespaces or libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue can't be worked at the moment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants