Try a different way again

neilenns · Dec 7, 2023 · 9969fb7 · 9969fb7
1 parent 2dcdce0
commit 9969fb7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -39,10 +39,7 @@ jobs:
 
       - name: Downgrade NSIS
         shell: pwsh
-        run: |
-          Invoke-WebRequest https://netcologne.dl.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04-setup.exe -OutFile C:\WINDOWS\Temp\nsis-3.04-setup.exe
-          Invoke-Expression "& C:\WINDOWS\Temp\nsis-3.04-setup.exe /S"
-          makensis.exe /VERSION
+        run: .\Build\downgrade_nsis.ps1
 
       - name: Restore NuGet packages
         working-directory: ${{env.GITHUB_WORKSPACE}}

diff --git a/Build/downgrade_nsis.ps1 b/Build/downgrade_nsis.ps1
@@ -5,7 +5,7 @@
 
 $NsisVersion = "3.04"
 Invoke-WebRequest "https://netcologne.dl.sourceforge.net/project/nsis/NSIS%203/${NsisVersion}/nsis-${NsisVersion}-setup.exe" -OutFile "C:\WINDOWS\Temp\nsis-${NsisVersion}-setup.exe"
-Invoke-Expression "& C:\WINDOWS\Temp\nsis-${NsisVersion}-setup.exe /S"
+Start-Process -Wait -FilePath "C:\WINDOWS\Temp\nsis-${NsisVersion}-setup.exe" -ArgumentList "/S"
 
 $NsisPath = "${env:ProgramFiles(x86)}\NSIS\"
 Add-MachinePathItem $NsisPath