Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a difficulty rating to each of the scenarios #38

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

gregoryduckworth
Copy link
Collaborator

@gregoryduckworth gregoryduckworth commented Nov 8, 2023

Pull Request

Description

Adds a difficulty rating to each of the scenarios. Rated out of 3 to signify Easy/Medium/Hard and a dropdown to filter by them.

Checklist

  • I have read the contribution guidelines.
  • This PR includes tests (or updates existing tests) that cover the changes.
  • Documentation has been updated (if applicable).
  • Code follows the project's coding standards.
  • All tests pass.

Screenshots (if applicable)

image
image

@e-taniguti
Copy link
Contributor

overall this is looking really nice !!!!
Here's my comment:
Screenshot 2023-11-09 at 16 08 37

@gregoryduckworth
Copy link
Collaborator Author

overall this is looking really nice !!!! Here's my comment: Screenshot 2023-11-09 at 16 08 37

I've fixed the behavioural issues on this now.

Then around the Various Inputs, do you mean the behaviour of the dropdown? As that should be covered by #16 or do you mean the icon? Either way they should be addressed in another PR to try and not conflate the two.

@e-taniguti
Copy link
Contributor

Agreed.

The idea was to add the "Search" input in the Various Inputs scenario.
There is no input with this style and behaviour there (label and x icon).

@gregoryduckworth
Copy link
Collaborator Author

Agreed.

The idea was to add the "Search" input in the Various Inputs scenario. There is no input with this style and behaviour there (label and x icon).

Yeah, good shout! I'll create an issue 👍

src/pages/Index.tsx Outdated Show resolved Hide resolved
src/pages/Index.tsx Outdated Show resolved Hide resolved
@gregoryduckworth gregoryduckworth merged commit 28c3f41 into main Nov 11, 2023
1 check passed
@gregoryduckworth gregoryduckworth deleted the difficulty branch November 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants