This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Update layout.tsx to fix 404 not rendering #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
force-pushed
the
acouch/404-fix
branch
from
5d4bf60
to
8f00e99
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 90.06% | 707/785 |
| 🟡 | Branches | 71.33% | 204/286 |
| 🟢 | Functions | 86.31% | 145/168 |
| 🟢 | Lines | 90.75% | 667/735 |
Test suite run success
155 tests passing in 47 suites.
Report generated by 🧪jest coverage report action from 8f00e99
andycochran
approved these changes
Sep 17, 2024
|
@andycochran great question. The root level layout is necessary, AFAICT, for the |
acouch
added a commit
that referenced
this pull request
Sep 18, 2024
acouch
added a commit
that referenced
this pull request
Sep 18, 2024
acouch
added a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
404 pages had the following issue:
This PR fixes that by adding the
<html><body>...in the top level layout.This error only appears in dev.
Time to review: 5 mins