This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #183] Opportunity Page Design Implementation #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Handing off to @acouch
|
acouch
changed the title
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 90.6% (+0.53% 🔼) |
790/872 |
| 🟡 | Branches | 71.79% (+0.47% 🔼) |
224/312 |
| 🟢 | Functions | 87.89% (+1.59% 🔼) |
167/190 |
| 🟢 | Lines | 91.27% (+0.52% 🔼) |
742/813 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / OpportunityDescription.tsx |
100% | 71.43% | 100% | 100% |
| 🟢 | ... / OpportunityAwardInfo.tsx |
91.3% | 62.5% | 100% | 90.91% |
| 🟢 | ... / OpportunityAwardGridRow.tsx |
100% | 100% | 100% | 100% |
| 🟢 | ... / OpportunityLink.tsx |
100% | 100% | 100% | 100% |
| 🟢 | ... / OpportunityIntro.tsx |
100% | 100% | 100% | 100% |
| 🟢 | ... / OpportunityStatusWidget.tsx |
91.67% | 0% | 100% | 90.91% |
| 🟢 | ... / OpportunityHistory.tsx |
100% | 50% | 100% | 100% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / breadcrumbs.ts |
68.18% (-1.82% 🔻) |
100% | 100% | 100% |
Test suite run success
178 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from be9f44e
I realized it can't be static behind the feature flag, so punting this.
✅ done
✅ done
@andycochran we talked about removing the breadcrumb since some agencies might want to have "hidden" opportunities. But realizing that since we are just surfacing opportunities from the search page, that that might not matter for now, and it would be better to leave it in? Thoughts? 
|
acouch
approved these changes
Sep 16, 2024
Let's leave it in for now and get feedback |
acouch
approved these changes
Sep 17, 2024
acouch
approved these changes
Sep 17, 2024
acouch
added a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2036 > What was added, updated, or removed in this PR. > Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified. > Screenshots, GIF demos, code examples or output to help show the changes working as expected. --------- Co-authored-by: Aaron Couch <[email protected]> Co-authored-by: Aaron Couch <[email protected]>
acouch
added a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2036 > What was added, updated, or removed in this PR. > Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified. > Screenshots, GIF demos, code examples or output to help show the changes working as expected. --------- Co-authored-by: Aaron Couch <[email protected]> Co-authored-by: Aaron Couch <[email protected]>
acouch
added a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
Fixes #2036 > What was added, updated, or removed in this PR. > Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified. > Screenshots, GIF demos, code examples or output to help show the changes working as expected. --------- Co-authored-by: Aaron Couch <[email protected]> Co-authored-by: Aaron Couch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #183
Time to review: x mins
Changes proposed
Context for reviewers
Additional information