Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Commit

Permalink
Minor comment adjustment
Browse files Browse the repository at this point in the history
  • Loading branch information
chouinar committed Sep 11, 2024
1 parent 31ca59e commit 0c1ed2e
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions api/src/services/opportunities_v1/search_opportunities.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,26 +107,22 @@ def _add_search_filters(

for field in filters.model_fields_set:
field_filters = getattr(filters, field)
field_name = _adjust_field_name(field)

# one_of filters translate to an opensearch term filter
# see: https://opensearch.org/docs/latest/query-dsl/term/terms/
# We use the type of the search filter to determine what methods
# we call on the builder. This way we can make sure we have the proper
# type mappings.
if isinstance(field_filters, StrSearchFilter) and field_filters.one_of:
builder.filter_terms(_adjust_field_name(field), field_filters.one_of)
builder.filter_terms(field_name, field_filters.one_of)

# TODO - docs / combine with the above?
elif isinstance(field_filters, BoolSearchFilter) and field_filters.one_of:
builder.filter_terms(_adjust_field_name(field), field_filters.one_of)
builder.filter_terms(field_name, field_filters.one_of)

# TODO - docs
elif isinstance(field_filters, IntSearchFilter):
builder.filter_int_range(
_adjust_field_name(field), field_filters.min, field_filters.max
)
builder.filter_int_range(field_name, field_filters.min, field_filters.max)

elif isinstance(field_filters, DateSearchFilter):
builder.filter_date_range(
_adjust_field_name(field), field_filters.start_date, field_filters.end_date
)
builder.filter_date_range(field_name, field_filters.start_date, field_filters.end_date)


def _add_aggregations(builder: search.SearchQueryBuilder) -> None:
Expand Down

0 comments on commit 0c1ed2e

Please sign in to comment.