-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LocationType Specification to DNA Center and Device42 #546
Open
jdrew82
wants to merge
17
commits into
develop
Choose a base branch
from
feat-add_loctypes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne file for easier re-use.
…as, Buildings, and Floors from DNAC.
…Sync models. Also update adapters and models to use the new attributes.
…nals as it is expected users will create these now and specify in Job form.
…support in case Controller is assigned Floor LocationType.
jdrew82
added
type: documentation
Issues/PRs addressing documentation.
type: major feature
integration: dna center
Issues/PRs for Cisco DNA Center integration.
labels
Sep 12, 2024
…e LocationType used for imported Buildings. Will resort to Site LocationType to align with previous handling of LocationType for Buildings.
… and Room DiffSync models.
I see some device42 commits in here, is this intended? |
jdrew82
changed the title
Add LocationType Specification to DNA Center
Add LocationType Specification to DNA Center and Device42
Sep 16, 2024
Yeah, that's intentional. I figured might as well update any of the integrations that could benefit from the option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
integration: device42
Issues/PRs for Device42 Integration
integration: dna center
Issues/PRs for Cisco DNA Center integration.
type: documentation
Issues/PRs addressing documentation.
type: major feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the DNA Center integration to add the capability to specify the LocationType for each of the types of location objects that are imported. I've also added the missing User documentation along with screenshots for how to use the integration and steps to add the required pieces.