Add startupProbe for nautobot deployment
#450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertzakis
force-pushed
the
add-startup-probes
branch
from
c55da3c
to
7b72fc2
Compare
ubajze
reviewed
Sep 27, 2024
charts/nautobot/values.yaml
Outdated
| # -- (Probe) [[ref](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes)] Nautobot startup probe | ||
| # @default -- See values.yaml | ||
| startupProbe: | ||
| enabled: true |
There was a problem hiding this comment.
Should we disable it by default? This may be better for a start. Then, when we thoroughly test it, we can enable it by default.
There was a problem hiding this comment.
Sure, please check again
gertzakis
force-pushed
the
add-startup-probes
branch
from
7b72fc2
to
83c4c45
Compare
ubajze
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #423
Adds
startupProbeinto values.yaml for Nautobot deployment. Configured with default values from Nautobot's docs.