Drop subscription on object read done #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema-drop-ordered-on-done
branch
from
650395a
to
a91398d
Compare
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
force-pushed
the
jarema-drop-ordered-on-done
branch
from
a91398d
to
38180ef
Compare
caspervonb
reviewed
Jul 4, 2023
| ))), | ||
| }, | ||
| Poll::Pending => Poll::Pending, | ||
| None => Poll::Ready(Err(std::io::Error::new( |
There was a problem hiding this comment.
Should we gracefully try to recover from this?
There was a problem hiding this comment.
I think that if the ordered consumer underneath cannot recover, this should not try either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix for ordered push consumer not being dropped as soon as object from Object Store is read.
Objectmight be valid for quite some time, so the subscription is running for no reason.