Add #[must_use] to Publish and refactor message ack calls

nats-io · Jul 31, 2023 · 2498525 · 2498525
1 parent 78243d1
commit 2498525
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/async-nats/src/client.rs b/async-nats/src/client.rs
@@ -44,6 +44,7 @@ impl From<tokio::sync::mpsc::error::SendError<Command>> for PublishError {
     }
 }
 
+#[must_use]
 pub struct Publish {
     sender: mpsc::Sender<Command>,
     subject: String,
@@ -79,7 +80,7 @@ impl IntoFuture for Publish {
     type IntoFuture = Pin<Box<dyn Future<Output = Result<(), PublishError>> + Send>>;
 
     fn into_future(self) -> Self::IntoFuture {
-        let sender = self.sender.clone();
+        let sender = self.sender;
         let subject = self.subject;
         let payload = self.payload;
         let respond = self.respond;

diff --git a/async-nats/src/jetstream/message.rs b/async-nats/src/jetstream/message.rs
@@ -89,9 +89,8 @@ impl Message {
             self.context
                 .client
                 .publish(reply.to_string(), "".into())
-                .into_future()
-                .map_err(Error::from)
                 .await
+                .map_err(Error::from)
         } else {
             Err(Box::new(std::io::Error::new(
                 std::io::ErrorKind::Other,
@@ -132,9 +131,8 @@ impl Message {
             self.context
                 .client
                 .publish(reply.to_string(), kind.into())
-                .into_future()
-                .map_err(Error::from)
                 .await
+                .map_err(Error::from)
         } else {
             Err(Box::new(std::io::Error::new(
                 std::io::ErrorKind::Other,