Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential busy loops #1213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix potential busy loops #1213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4930ae2
Fix potential busy loop during reconnectMode
MauriceVanVeen Aug 20, 2024
bf118be
Merge branch 'main' into fix-potential-busy-loops
scottf Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/nats/client/impl/NatsConnectionWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ void sendMessageBatch(NatsMessage msg, DataPort dataPort, StatisticsCollector st
@Override
public void run() {
Duration outgoingTimeout = Duration.ofMinutes(2); // This can be long since no one is sending
Duration reconnectTimeout = Duration.ofMillis(1); // This should be short, since we are trying to get the reconnect through
Duration reconnectTimeout = Duration.ofMillis(100); // This should be short, since we are trying to get the reconnect through

try {
dataPort = this.dataPortFuture.get(); // Will wait for the future to complete
Expand Down
Loading