Extend conditional #7851

khalidadil · 2024-09-19T20:05:36Z

Closes

Describe your changes:

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Has this been smoke tested?
Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
Have you associated a milestone with this PR? Note: leave blank if unsure.
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?

… for historical conditional telemetry queries to allow for plotting

khalidadil · 2024-09-19T20:06:44Z

src/plugins/plot/stackedPlot/StackedPlotItem.vue

@@ -243,6 +243,7 @@ export default {
          domainObject: {
            ...this.childObject,
            configuration: {
+              ...this.childObject.configuration,


Fixes a bug with stacked plots

khalidadil · 2024-09-19T20:07:06Z

src/plugins/plot/tickUtils.js

@@ -94,7 +94,7 @@ export function ticks(start, stop, count) {
 }

 export function commonPrefix(a, b) {
-  const maxLen = Math.min(a.length, b.length);
+  const maxLen = Math.min(a.length, b?.length);


Fixes an issue with undefined telemetry in plots

khalidadil · 2024-09-19T20:07:15Z

src/plugins/plot/tickUtils.js

@@ -110,7 +110,7 @@ export function commonPrefix(a, b) {
 }

 export function commonSuffix(a, b) {
-  const maxLen = Math.min(a.length, b.length);
+  const maxLen = Math.min(a.length, b?.length);


Same as above

src/plugins/condition/historicalTelemetryProvider.js

+          const conditionDetails = conditionCollectionMap.get(id);
+          const { isDefault } = conditionDetails;
+          const conditionConfiguration = conditionDetails?.configuration;
+          const { outputTelemetry, outputMetadata, output } = conditionConfiguration;


src/plugins/condition/historicalTelemetryProvider.js

+          const conditionDetails = conditionCollectionMap.get(id);
+          const { isDefault } = conditionDetails;
+          const conditionConfiguration = conditionDetails?.configuration;
+          const { outputTelemetry, outputMetadata, output } = conditionConfiguration;


src/plugins/condition/historicalTelemetryProvider.js

+    const outputTelemetryList = [];
+    const domainObject = this.conditionSetDomainObject;
+    outputTelemetryMap.forEach((outputMetadata, timestamp) => {
+      const { condition, telemetry, value } = outputMetadata;


codecov · 2024-09-19T20:09:57Z

Codecov Report

Attention: Patch coverage is 7.63359% with 242 lines in your changes missing coverage. Please review.

Project coverage is 55.70%. Comparing base (73489cd) to head (21e94fd).

Files with missing lines	Patch %	Lines
...c/plugins/condition/historicalTelemetryProvider.js	0.00%	156 Missing ⚠️
src/plugins/condition/ConditionManager.js	32.60%	31 Missing ⚠️
src/plugins/condition/components/ConditionItem.vue	0.00%	21 Missing ⚠️
src/plugins/condition/components/TestData.vue	0.00%	10 Missing ⚠️
...lugins/condition/ConditionInspectorViewProvider.js	18.18%	9 Missing ⚠️
...ugins/condition/components/ConditionCollection.vue	0.00%	9 Missing ⚠️
...dition/components/ConditionInspectorConfigView.vue	0.00%	4 Missing ⚠️
...plugins/condition/ConditionSetTelemetryProvider.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                        Coverage Diff                        @@
##           conditional-style-performance    #7851      +/-   ##
=================================================================
- Coverage                          58.78%   55.70%   -3.08%     
=================================================================
  Files                                675      678       +3     
  Lines                              27277    27532     +255     
  Branches                            2671     2680       +9     
=================================================================
- Hits                               16034    15336     -698     
- Misses                             11195    12148     +953     
  Partials                              48       48

Flag	Coverage Δ
e2e-ci	`50.07% <2.29%> (-11.70%)`	⬇️
e2e-full	`23.18% <1.37%> (-0.35%)`	⬇️
unit	`50.82% <7.63%> (-0.39%)`	⬇️

Files with missing lines	Coverage Δ
src/plugins/condition/components/CriterionItem.vue	`0.00% <ø> (ø)`
src/plugins/condition/plugin.js	`100.00% <100.00%> (ø)`
src/plugins/plot/stackedPlot/StackedPlotItem.vue	`46.26% <ø> (ø)`
src/plugins/plot/tickUtils.js	`97.18% <100.00%> (ø)`
...plugins/condition/ConditionSetTelemetryProvider.js	`19.04% <0.00%> (-75.96%)`	⬇️
...dition/components/ConditionInspectorConfigView.vue	`0.00% <0.00%> (ø)`
...lugins/condition/ConditionInspectorViewProvider.js	`18.18% <18.18%> (ø)`
...ugins/condition/components/ConditionCollection.vue	`0.00% <0.00%> (ø)`
src/plugins/condition/components/TestData.vue	`0.00% <0.00%> (ø)`
src/plugins/condition/components/ConditionItem.vue	`0.00% <0.00%> (ø)`
... and 2 more

... and 85 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73489cd...21e94fd. Read the comment docs.

davetsay · 2024-09-20T21:05:00Z

Just want to say its great to see a PR by @khalidadil again, 🥲

khalidadil · 2024-09-21T23:20:37Z

Just want to say its great to see a PR by @khalidadil again, 🥲

Thanks Dave! Still got some bugs to iron out and it needs tests, but it's getting there!

Add realtime output of telemetry data in conditionals and add support…

23cf829

… for historical conditional telemetry queries to allow for plotting

khalidadil changed the base branch from master to conditional-style-performance September 19, 2024 20:06

khalidadil commented Sep 19, 2024

View reviewed changes

github-advanced-security bot found potential problems Sep 19, 2024

View reviewed changes

Cleanup and add missing files

21e94fd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend conditional #7851

Extend conditional #7851

khalidadil commented Sep 19, 2024

khalidadil Sep 19, 2024

khalidadil Sep 19, 2024

khalidadil Sep 19, 2024

codecov bot commented Sep 19, 2024 •

edited

Loading

davetsay commented Sep 20, 2024

khalidadil commented Sep 21, 2024

Extend conditional #7851

Are you sure you want to change the base?

Extend conditional #7851

Conversation

khalidadil commented Sep 19, 2024

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

khalidadil Sep 19, 2024

Choose a reason for hiding this comment

khalidadil Sep 19, 2024

Choose a reason for hiding this comment

khalidadil Sep 19, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 19, 2024 • edited Loading

Codecov Report

davetsay commented Sep 20, 2024

khalidadil commented Sep 21, 2024

codecov bot commented Sep 19, 2024 •

edited

Loading