Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar graphs should only get latest historical datum #7811

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions e2e/tests/functional/plugins/plot/barGraph.e2e.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
/*****************************************************************************
* Open MCT, Copyright (c) 2014-2024, United States Government
* as represented by the Administrator of the National Aeronautics and Space
* Administration. All rights reserved.
*
* Open MCT is licensed under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0.
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
* Open MCT includes source code licensed under additional open source
* licenses. See the Open Source Licenses file (LICENSES.md) included with
* this source code distribution or the Licensing information page available
* at runtime from the About dialog for additional information.
*****************************************************************************/

/*
* This test suite is dedicated to testing the Bar Graph component.
*/

import { v4 as uuid } from 'uuid';

import { createDomainObjectWithDefaults } from '../../../../appActions.js';
import { expect, test } from '../../../../pluginFixtures.js';

test.describe('Bar Graph', () => {
let barGraph;

test.beforeEach(async ({ page }) => {
// Open a browser, navigate to the main page, and wait until all networkevents to resolve
await page.goto('./', { waitUntil: 'domcontentloaded' });

// Create the Bar Graph
barGraph = await createDomainObjectWithDefaults(page, { type: 'Graph' });
});

test('Requests a single historical datum', async ({ page }) => {
// Create a sine wave generator within the bar graph
await createDomainObjectWithDefaults(page, {
unlikelyzero marked this conversation as resolved.
Show resolved Hide resolved
type: 'Sine Wave Generator',
name: `swg-${uuid()}`,
unlikelyzero marked this conversation as resolved.
Show resolved Hide resolved
parent: barGraph.uuid
});
const getRequestOptionsPromise = addTelemetryInterceptor(page);

// Navigate to the bar graph and verify that
await page.goto(barGraph.url, { waitUntil: 'domcontentloaded' });
await page.getByRole('tab', { name: 'Config' }).click();

const requestOptions = await getRequestOptionsPromise;
await expect(requestOptions.strategy).toBe('latest');
await expect(requestOptions.size).toBe(1);
});
});

/**
* Util for returning the size option for telemetry requests
* @param {import('@playwright/test').Page} page
*/
async function addTelemetryInterceptor(page) {
const getRequestOptionsPromise = new Promise((resolve) =>
page.exposeFunction('getRequestOptions', resolve)
);

await page.evaluate(() => {
function requestOptionsChecker() {
return {
appliesTo: () => {
return true;
},
invoke: (request) => {
window.getRequestOptions({
strategy: request.strategy,
size: request.size
});
return request;
}
};
}
window.openmct.telemetry.addRequestInterceptor(requestOptionsChecker());
});

return getRequestOptionsPromise;
}
4 changes: 3 additions & 1 deletion src/plugins/charts/bar/BarGraphView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,9 @@ export default {

return {
end,
start
start,
size: 1,
strategy: 'latest'
};
shefalijoshi marked this conversation as resolved.
Show resolved Hide resolved
},
loadComposition() {
Expand Down
Loading