-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add news item for Circulars over Kafka and schema v4.1.0 #2369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we wait until we have merged nasa-gcn/gcn-schema#154 to announce this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also advertise the new heartbeat topic?
d4e5224
to
66de701
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2369 +/- ##
========================================
- Coverage 5.27% 5.26% -0.01%
========================================
Files 157 158 +1
Lines 3906 3912 +6
Branches 419 419
========================================
Hits 206 206
- Misses 3699 3705 +6
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be consistent about whether the bullet points end with punctuation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said before:
Be consistent about whether the bullet points end with punctuation.
2b0a472
to
8d8efb0
Compare
Co-authored-by: Leo Singer <[email protected]>
When you merge a PR on which you made multiple fixup commits, please squash your changes. |
Description
This PR provides a news item for Circulars over Kafka and schema v4.1.0.
Related Issue(s)
Resolves #2343