Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add news item for Circulars over Kafka and schema v4.1.0 #2369

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

jracusin
Copy link
Contributor

@jracusin jracusin commented Jun 14, 2024

Description

This PR provides a news item for Circulars over Kafka and schema v4.1.0.

Related Issue(s)

Resolves #2343

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we wait until we have merged nasa-gcn/gcn-schema#154 to announce this.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also advertise the new heartbeat topic?

app/routes/news._index.mdx Outdated Show resolved Hide resolved
@jracusin jracusin changed the title Add news item for Circulars over Kafka Add news item for Circulars over Kafka and schema v4.1.0 Jul 29, 2024
app/root.tsx Outdated Show resolved Hide resolved
app/routes/news._index.mdx Outdated Show resolved Hide resolved
app/routes/news._index.mdx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.26%. Comparing base (46ec6cc) to head (cfd0c49).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2369      +/-   ##
========================================
- Coverage   5.27%   5.26%   -0.01%     
========================================
  Files        157     158       +1     
  Lines       3906    3912       +6     
  Branches     419     419              
========================================
  Hits         206     206              
- Misses      3699    3705       +6     
  Partials       1       1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be consistent about whether the bullet points end with punctuation.

app/routes/news._index.mdx Outdated Show resolved Hide resolved
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said before:

Be consistent about whether the bullet points end with punctuation.

@jracusin jracusin requested a review from lpsinger July 30, 2024 19:31
app/routes/news._index.mdx Outdated Show resolved Hide resolved
app/routes/news._index.mdx Outdated Show resolved Hide resolved
app/routes/news._index.mdx Outdated Show resolved Hide resolved
@jracusin jracusin requested a review from lpsinger July 30, 2024 19:49
@jracusin jracusin merged commit d363318 into nasa-gcn:main Jul 30, 2024
10 checks passed
@jracusin jracusin deleted the circulars-kafka branch July 30, 2024 19:56
@lpsinger
Copy link
Member

When you merge a PR on which you made multiple fixup commits, please squash your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add announcement for GCN Circulars over Kafka and schema release
2 participants