Add EP trigger id #160
Merged
Add EP trigger id #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -2,6 +2,7 @@ | |||
| "$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/einstein_probe/wxt/alert.schema.json", | |||
| "instrument": "WXT", | |||
| "trigger_time": "2024-03-01T21:46:05.13Z", | |||
| "id": ["01708973486"], | |||
There was a problem hiding this comment.
Hi @modot, thanks. Would EP Team keep ingesting the ID no. in Circulars as well?
There was a problem hiding this comment.
Yes, absolutely. We are ready to start including the ID for both Notices and Circulars. If I understand correctly, are we good to proceed with the new format now?
Vidushi-GitHub
approved these changes
Jul 16, 2024
|
close: #159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in previous PR #155 and #159 ,
we prefer to use trigger id as the unique identifier. This PR add
idproperty to EP Notice schema and example file.