Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guano schema: snake_case #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vidushi-GitHub
Copy link
Member

Description

For consistency, Guano schema files names are modified to snake_case format.
These are just examples, should n't break anything.

Somehow id field is in correct format: "$id": "https://gcn.nasa.gov/schema/main/gcn/notices/swift/bat/guano.schema.json"
Notice is already in lower case: "gcn.notices.swift.bat.guano"

Related PR:
#147

P.S. See if we wanna confirm this with someone from Swift team?

Copy link
Contributor

@dakota002 dakota002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vidushi-GitHub if you change the schema name to be lowercase ('guano') you need to update the $schema properties so that it is still valid, which means this is also technically a breaking change.

@Vidushi-GitHub
Copy link
Member Author

@Vidushi-GitHub if you change the schema name to be lowercase ('guano') you need to update the $schema properties so that it is still valid, which means this is also technically a breaking change.

It dint seem breaking for validation.

@lpsinger
Copy link
Member

lpsinger commented Jun 7, 2024

@Vidushi-GitHub if you change the schema name to be lowercase ('guano') you need to update the $schema properties so that it is still valid, which means this is also technically a breaking change.

It dint seem breaking for validation.

That's a bug in our validation, then. URLs are generally case-sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants