Include igwn notices in JSON loop #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
approved these changes
Mar 5, 2024
lpsinger
requested changes
Mar 5, 2024
| @@ -106,7 +106,7 @@ def kafka_message_to_email(message): | |||
| maintype="application", | |||
| subtype="xml", | |||
| ) | |||
| elif topic.startswith("gcn.notices."): | |||
| elif topic.startswith("gcn.notices.") or topic.startswith("igwn."): | |||
There was a problem hiding this comment.
Note that you need to subscribe to the topic as well in subscribe_to_topics.
There was a problem hiding this comment.
🤦♂️ good catch, added in latest commit
|
Crap. I remember why we hadn't pushed ahead on this. The IGWN alerts are only public on production. This work is blocked until we model the Kafka ACL permissions. |
Ah gotcha. What all is needed for modeling the ACL permissions? I started doing some work a while ago to add some of the group functionality to the website: nasa-gcn/gcn.nasa.gov#1879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #174