LVC binary conversions #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit int conversion removed MAXI_UNKNOWN conversion Removed GECAM_FLT and GECAM_GND conversion Added documentation and changed function name reformatted file deleted files
lpsinger
reviewed
Aug 26, 2024
There was a problem hiding this comment.
I am not sure whether we should convert this notice type or not, given that we have native JSON alerts for IGWN/LVK already. @Vidushi-GitHub, @jracusin, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has the binary conversions for LVC_PRELIMINARY, LVC_INITIAL, LVC_UPDATE and LVC_RETRACTION. I defined the following new fields which were not in the core schema:
There is a bit which says that some of these notices were only distributed internally. Additionally, some of the these example.json were not present in the archive. I have not added this information to the conversion. The description for the bit is below: