SWIFT_BAT_GRB_POS_ACK conversion #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit int conversion removed MAXI_UNKNOWN conversion Removed GECAM_FLT and GECAM_GND conversion Added documentation and changed function name reformatted file deleted files
lpsinger
requested changes
Aug 7, 2024
lpsinger
requested changes
Aug 7, 2024
|
@parsotat, would you please review this? |
…sary equalities changed Unused to intentionally omitted reformated comments
lpsinger
requested changes
Aug 9, 2024
lpsinger
requested changes
Aug 26, 2024
Comment on lines
43
to
45
| comments = "\n".join( | ||
| [val for (key, val) in flag_descriptions.items() if (soln_status_bits[key])] | ||
| ) |
There was a problem hiding this comment.
Please capture these flags in a machine-readable way, not as comments.
There was a problem hiding this comment.
I use additional_info to capture the data stored in the COMMENTS: fields in the text notices. Some of these are redundant with the data in the notices and can be removed(I've mainly added them for completeness). However, some of the these comments I think may be too complex to easily translate into a field like "StarTracker not locked so trigger probably bogus" or "This was orginally a SubTresh, but it is now converted to a real BAT_POS.".
added 2 commits
September 12, 2024 23:06
f#inished comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SWIFT_BAT_* notices have a very similar similar conversion with just a few differing/missing fields. So if the format is acceptable I could commit the rest of the conversions to this pull request as well.
The following keywords do not exist in the core schema for SWIFT_BAT_GRB_POS_ACK: