fix/playground spaces and select offset

nank1ro · May 19, 2024 · 94df8b9 · 94df8b9
1 parent e4094fd
commit 94df8b9
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 17 deletions.
diff --git a/lib/src/components/select.dart b/lib/src/components/select.dart
@@ -252,7 +252,7 @@ class ShadSelectState<T> extends State<ShadSelect<T>> {
         const ShadAnchor(
           childAlignment: Alignment.bottomLeft,
           overlayAlignment: Alignment.topLeft,
-          offset: Offset(4, 0),
+          offset: Offset.zero,
         );
 
     final Widget effectiveText;
@@ -561,6 +561,8 @@ class _ShadOptionState<T> extends State<ShadOption<T>> {
       child: Focus(
         focusNode: focusNode,
         child: ShadGestureDetector(
+          behavior: HitTestBehavior.opaque,
+          cursor: SystemMouseCursors.click,
           onHoverChange: (value) {
             hovered.value = value;
             if (value) focusNode.requestFocus();

diff --git a/lib/src/theme/themes/component_defaults.dart b/lib/src/theme/themes/component_defaults.dart
@@ -303,7 +303,7 @@ abstract class ShadDefaultComponentThemes {
       anchor: const ShadAnchor(
         childAlignment: Alignment.bottomLeft,
         overlayAlignment: Alignment.topLeft,
-        offset: Offset(4, 0),
+        offset: Offset.zero,
       ),
     );
   }

diff --git a/playground/lib/pages/form.dart b/playground/lib/pages/form.dart
@@ -1,6 +1,5 @@
 // ignore_for_file: avoid_print
 
-import 'package:awesome_flutter_extensions/awesome_flutter_extensions.dart';
 import 'package:flutter/material.dart';
 import 'package:shadcn_ui/shadcn_ui.dart';
 
@@ -129,14 +128,12 @@ class _FormPageState extends State<FormPage> {
                     FormStyle.radioField =>
                       ShadRadioGroupFormField<NotifyAbout>(
                         label: const Text('Notify me about'),
-                        items: NotifyAbout.values
-                            .map(
-                              (e) => ShadRadio(
-                                value: e,
-                                label: Text(e.message),
-                              ),
-                            )
-                            .separatedBy(const SizedBox(height: 4)),
+                        items: NotifyAbout.values.map(
+                          (e) => ShadRadio(
+                            value: e,
+                            label: Text(e.message),
+                          ),
+                        ),
                         validator: (v) {
                           if (v == null) {
                             return 'You need to select a notification type.';

diff --git a/playground/lib/pages/radio_group.dart b/playground/lib/pages/radio_group.dart
@@ -1,4 +1,3 @@
-import 'package:awesome_flutter_extensions/awesome_flutter_extensions.dart';
 import 'package:flutter/material.dart';
 import 'package:shadcn_ui/shadcn_ui.dart';
 
@@ -9,10 +8,10 @@ class RadioGroupPage extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return Scaffold(
+    return const Scaffold(
       body: Center(
         child: ShadRadioGroup<String>(
-          items: const [
+          items: [
             ShadRadio(
               label: Text('Default'),
               value: 'default',
@@ -25,7 +24,7 @@ class RadioGroupPage extends StatelessWidget {
               label: Text('Nothing'),
               value: 'nothing',
             ),
-          ].separatedBy(const SizedBox(height: 4)),
+          ],
         ),
       ),
     );

diff --git a/playground/web/index.html b/playground/web/index.html
@@ -85,14 +85,13 @@
   <script>
     window.addEventListener('load', function () {
       const loader = document.querySelector('.loader');
-      _flutter.loader.load({
+      _flutter.loader.loadEntrypoint({
         serviceWorker: {
           serviceWorkerVersion: serviceWorkerVersion,
         }
       }).then(function (engineInitializer) {
         return engineInitializer.initializeEngine();
       }).then(function (appRunner) {
-        console.log('appRunner', appRunner);
         loader.remove();
         return appRunner.runApp();
       }).then(function (app) {