Hoisting group fetching, take 2 #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5189 +/- ##
==========================================
- Coverage 82.50% 82.41% -0.09%
==========================================
Files 406 407 +1
Lines 31743 31778 +35
Branches 5050 5051 +1
==========================================
+ Hits 26188 26191 +3
- Misses 4065 4096 +31
- Partials 1490 1491 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davea
approved these changes
Sep 27, 2024
If a category is in a group on its own, the reporting form hoists it up to the top level, to save a pointless extra step. In doing so, it was no longer getting the associated group to store for submission. Rewrite the input so it is clearer as to what we are receiving.
dracos
force-pushed
the
fd-4535-hoisted-category-groups
branch
from
f5abf32
to
2218b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #5175 are all in the fixup commit.
Refactored the category creation a bit to make it easier to add categories-in-groups.
And have mistakingly included a commit removing some old mixins, sorry, but hey, that's straightforward enough.
[skip changelog]