Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSO button use separate form. #5178

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Make SSO button use separate form. #5178

merged 1 commit into from
Sep 23, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Sep 19, 2024

This reduces confusion if a browser auto-fills the email form but someone still clicks the SSO button, or similar. [skip changelog]

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (e9b3d1d) to head (cf7e084).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
- Coverage   82.50%   82.48%   -0.02%     
==========================================
  Files         406      406              
  Lines       31725    31728       +3     
  Branches     5048     5048              
==========================================
- Hits        26174    26172       -2     
- Misses       4060     4065       +5     
  Partials     1491     1491              
Flag Coverage Δ
82.48% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos requested a review from davea September 19, 2024 12:31
This reduces confusion if a browser auto-fills the email form but
someone still clicks the SSO button, or similar.
@dracos dracos merged commit cf7e084 into master Sep 23, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants