Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full name is aria-required in report creation #5169

Merged

Conversation

chrismytton
Copy link
Member

Ensure the full name field is marked as required for screen readers.

Fixes https://github.com/mysociety/societyworks/issues/4492

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (cf7e084) to head (eff944d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5169   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files         406      406           
  Lines       31728    31728           
  Branches     5048     5048           
=======================================
  Hits        26172    26172           
  Misses       4065     4065           
  Partials     1491     1491           
Flag Coverage Δ
82.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason these aren't required is because that can cause issues with the multi-page nature of the form (ie. these being required but on a non-visible page if you're signing in rather than giving your name). The JS in fixmystreet.js already adding required and aria-required and removing, as far as I can see, under "set correct required status depending on what we submit", which @chrismytton you added, so I'd be worried this e.g. made the sign in form unsubmittable for screenreaders. I'd like more details from the person complaining, I think, before we add this, as to the circumstance when it didnt' have aria-required?
Or perhaps aria-required doesn't matter so much. But it's not required if they're signing in is my point, iyswim.
I guess the JS is removing it if you click sign in, so 🤷 guess it doesn't matter if required at the time it loads, hmm.

@mysociety-pusher mysociety-pusher force-pushed the surrey-accessibility-aria-required-full-name branch from 523289d to 041849b Compare September 23, 2024 10:19
Ensure the full name field is marked as required for screen readers.
@mysociety-pusher mysociety-pusher force-pushed the surrey-accessibility-aria-required-full-name branch from 041849b to eff944d Compare September 23, 2024 10:49
@mysociety-pusher mysociety-pusher merged commit eff944d into master Sep 23, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants