[Bromley] Create 'Investigation Required' events for comments on closed Echo-backed reports. #4869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4869 +/- ##
==========================================
+ Coverage 82.66% 83.90% +1.24%
==========================================
Files 404 408 +4
Lines 31462 35508 +4046
Branches 4988 6157 +1169
==========================================
+ Hits 26008 29793 +3785
- Misses 3975 4168 +193
- Partials 1479 1547 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
neprune
force-pushed
the
bromley-echo-reopen
branch
from
6c83b37
to
e4abf0c
Compare
neprune
changed the title
neprune
force-pushed
the
bromley-echo-reopen
branch
2 times, most recently
from
88652a0
to
63ed4e0
Compare
neprune
force-pushed
the
bromley-echo-reopen
branch
from
63ed4e0
to
bc42be7
Compare
dracos
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Looks good. I'm just tidying it up now with my phase2 thing and will then try and put on staging. I think for my phase2 I changed the category rather than use a hidden one as you have here, your way might be preferable depending on how it looks, but can see during testing I guess!
dracos
force-pushed
the
bromley-echo-reopen
branch
from
bc42be7
to
845bac1
Compare
dracos
approved these changes
Mar 8, 2024
mysociety-pusher
force-pushed
the
bromley-echo-reopen
branch
from
315bc42
to
5b8f3af
Compare
dracos
force-pushed
the
bromley-echo-reopen
branch
2 times, most recently
from
60f8b62
to
359d970
Compare
When adding the comment data to the notes field include the user details with the comment in the format requested mysociety/societyworks#4232
Ingore any updates from Echo that aren't New/Completed and don't have a resolution code.
Without doing this, if the Echo report is closed again with the same resolution code (which maps to external status code), the response template is not located because that only looks for external status code templates if the external status code has changed.
Using the same handover_notes as Echo to Bromley means that they will be automatically added to the detail when sent, and included in the Notes, as well as the report details.
dracos
force-pushed
the
bromley-echo-reopen
branch
from
bdc15c0
to
e3bf28d
Compare
Both the parent and client event updates are coming through to us on the same report, as they have the same client reference, and the parent event GUID is the one stored on the report, but we need to look up the child event when we receive an update on the child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]
closes https://github.com/mysociety/societyworks/issues/3267
Example on staging: https://staging.fixmystreet.com/admin/report_edit/23736