fix: Populate topics from Gitlab #887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit propages the topics from Gitlab project response into prometheus stats Fixes mvisonneau#697
sponte
changed the title
sponte
changed the title
The projects are read from the config, but retrieved from Gitlab through pull configuration. This is to enable scraping of the configuration data e.g. Topics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are included in this PR:
config.Projectssimilarly to howconfig.Wildcardswork - previously the projects configuration was not validated directly in Gitlab and hence the topics were not retrieved.PullProjects, but it does inPullProjectsFromWildcards)Fixes #697