fix: use keyset pagination only when it is supported #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-conditional-keyset-pagination
branch
from
b1f6d23
to
daba1a1
Compare
stanhu
force-pushed
the
sh-conditional-keyset-pagination
branch
from
daba1a1
to
8e62767
Compare
stanhu
force-pushed
the
sh-conditional-keyset-pagination
branch
2 times, most recently
from
430154c
to
6c0ace3
Compare
mvisonneau#744 switched to keyset pagination for the `/api/v4/projects/:id/jobs` API endpoint, but this feature is only available in GitLab 15.9 and later (https://docs.gitlab.com/ee/api/jobs.html#list-project-jobs). This commit retrieves the instance metadata at startup to determine whether keyset pagination is available. If the metadata is not available or returns a version < 15.9, offset pagination will be used.
stanhu
force-pushed
the
sh-conditional-keyset-pagination
branch
from
6c0ace3
to
45dc3ed
Compare
|
@mvisonneau Could you take a look? |
stanhu
force-pushed
the
sh-conditional-keyset-pagination
branch
from
b6844da
to
73dd2d3
Compare
|
@mvisonneau Thanks! Could I trouble you for a release? |
|
Thank you for v0.5.6! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#744 switched to keyset pagination for the
/api/v4/projects/:id/jobsAPI endpoint, but this feature is only available in GitLab 15.9 and later (https://docs.gitlab.com/ee/api/jobs.html#list-project-jobs).This commit retrieves the instance metadata at startup to determine whether keyset pagination is available. If the metadata is not available or returns a version < 15.9, offset pagination will be used.