Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Musescore 4 #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Jojo-Schmitz
Copy link

while mantaining ful Mu3 compatibility.
Also some code formatting/indenting.

And adding Chromatic 16Hole harmonica

while mantaining ful Mu3 compatibility.
Also some code formatting/indenting.
@jokrefta
Copy link

Changing Qt.quit() to quit() seems to have broken Musescore 3 compatibility. I tried this in Musescore 3.6.2 and it doesn't seem to work quite right. When you apply the changes in the popup window it doesn't close it. Plugin Creator shows the error ReferenceError: quit is not defined

@Jojo-Schmitz
Copy link
Author

Jojo-Schmitz commented Sep 17, 2023

Yes, but that error is harmless.
To close the window other means are available though.

But try (typeof(quit) === 'undefined' ? Qt.quit : quit)()
as taken from https://musescore.org/en/node/337468

@jokrefta
Copy link

That seems to work correctly in both versions

it is harmless but emits error messages in the Plugin cerator console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants